s/Ferrocene Language Specification/FLS and update README#564
Conversation
JoelMarcey
requested review from
ehuss,
emilyalbini,
joshtriplett,
nikomatsakis and
traviscross
| copyright = "The Ferrocene Developers and The Rust Project Contributors" | ||
| author = "The Ferrocene Developers and The Rust Project Contributors" |
There was a problem hiding this comment.
Do we just want to boil this down to "The Rust Project Contributors"? At this point, given what's been done, I think we could consider the Ferrocene Developers to be Rust Project Contributors as well.
There was a problem hiding this comment.
Under the agreement of the transfer, we would leave existing copyright in place and add new copyright for any changes or updates. New files we would just put "The Rust Project Contributors".
There was a problem hiding this comment.
Yes... I had flagged this one because it's not a header on this file, it's a configuration that will apply this everywhere, to both old things as well as new ones. My reading is that, due to the CLA and the wording of the Apache 2.0 license, which specifically defines:
"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.
that all the existing authors would be "Rust Project Contributors" and so consolidating it would be OK for this cross-project purpose, and then on each file, we'd keep the individual copyright lines as you say. But it's OK either way.
|
Thanks @JoelMarcey for the PR. Overall, this looks pretty good. I've left some notes. I'll review again when it is passing CI. |
There was a problem hiding this comment.
This whole file is pretty much specific to Ferrocene, I don't think most of the content applies to the Rust project.
There was a problem hiding this comment.
Yeah, I am going to do another pass across some of these files in a separate PR.
| <header> | ||
| <a href="{{ pathto('index') }}"> | ||
| <img src="{{ pathto('_static/ferrocene.svg', 1) }}" alt="Ferrocene logo"> | ||
| <img src="{{ pathto('_static/rust-lang.svg', 1) }}" alt="Ferrocene logo"> |
There was a problem hiding this comment.
Nit: alt text still mentions Ferrocene.
| We released the Ferrocene Language Specification (FLS) publicly under an open | ||
| source license. That's always been our goal, and since we announced our effort, | ||
| a lot of people and organizations expressed their interest in it! | ||
| The FLS is released publicly under an open source license, specifically MIT and Apache 2.0. |
There was a problem hiding this comment.
There is still trailing whitespace (i.e. spaces that follow the last visible character) on this line and elsewhere in this diff. Also, this line needs to be wrapped.
traviscross
force-pushed
the
ferrocene-language-specification-to-fls
branch
from
514339b to
0e295ea
Compare
|
Pushed a squashing rebase. |
This works to replace "Ferrocene Language Specification" with "FLS" across the document until we come up with our preferred name to replace the FLS. This includes removing the Ferrocene logo and replacing it with the Rust Project logo in the sidebar. This also updates the README to provide appropriate credit to Ferrous Systems and provide the history of the FLS when it was the Ferrocene Language Specification.
traviscross
force-pushed
the
ferrocene-language-specification-to-fls
branch
from
0e295ea to
8d1630c
Compare
4 participants
This works to replace the Ferrocene Language Specification with FLS across the document until we come up with our preferred name to replace the FLS.
This includes removing the Ferrocene logo and replacing it with the Rust Project logo in the sidebar.
This also updates the README to provide appropriate credit to Ferrous and provide the history of the FLS when it was the Ferrocene Language Specification.