Add background section to FLS#565
Merged
traviscross merged 2 commits intorust-lang:mainfrom Jun 3, 2025
Merged
Conversation
The purpose of this is two fold: 1. Ensuring we acknowledge the contributions of Ferrous, etc. in the development of the FLS within the document itself. It will be placed as a section in the Appendix. 2. Acutally build and publish the FLS itself. I believe, if I am reading the GitHub Action workflow correctly, we have to use bors (via `bors merge`) in order to activate the publishing to GitHub Pages. Let's try that.
JoelMarcey
requested review from
ehuss,
joshtriplett,
nikomatsakis and
traviscross
Member
|
#556 removed the use of bors in favor of github merge queues |
Contributor
Author
|
Ah right. Thanks for the reminder on that. So how does that get activated to trigger the GitHub Pages build run? For example, I noticed that the PR I had last night didn't trigger a GitHub Pages build run from the CI workflow. |
Member
|
looks like it should just work, provided CI |
traviscross
reviewed
Jun 2, 2025
traviscross
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this is two fold:
bors merge) in order to activate the publishing to GitHub Pages. Let's try that. We may have to do some configuration to make this work. For example, previous PRs that updated the documented usedbors mergeand then thebors_ferrocenebot took action to build and publish. See fix broken link #554 for an example. So we may want to use a Rut Project bors bot instead.