Shared: fix shared futures missing wake up#2899
Open
zekun000 wants to merge 1 commit into
Open
Conversation
Author
|
doesn't look like I can add reviewers or labels, manually tag here @taiki-e , would appreciate feedbacks or loop in proper reviewers, thanks |
Member
|
cc @steffahn |
Member
|
Thanks for the ping, I think I even saw this PR before and forgot about it again. I guess I'll have to re-read my own issue first to understand what exactly needed fixing. |
Collaborator
|
☔ The latest upstream changes (possibly #3001) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an attempt to fix #2706
the waker mutex is used to protect the state transition that involves wakers (add, wake, re-wake), if a waker is called during the polling, it sets the state to
WOKEN_DURING_POLLINGthen the polling thread re-checks for potential new wakers and set state back to IDLE under the same mutex to avoid the race condition.an unit test is adopted from the issue and added, without the fix, it'll be stuck within 5 loops on my laptop locally.