Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
--- updated-dependencies: - dependency-name: spin dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
``` error: unnecessary parentheses around type --> futures-util/src/future/future/remote_handle.rs:72:57 | 72 | type SendMsg<Fut> = Result<<Fut as Future>::Output, Box<(dyn Any + Send + 'static)>>; | ^ ^ | = note: `-D unused-parens` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_parens)]` help: remove these parentheses | 72 - type SendMsg<Fut> = Result<<Fut as Future>::Output, Box<(dyn Any + Send + 'static)>>; 72 + type SendMsg<Fut> = Result<<Fut as Future>::Output, Box<dyn Any + Send + 'static>>; | ```
```
error: trait `Fn1` is never used
--> futures-util/src/fns.rs:34:11
|
34 | pub trait Fn1<A>: FnMut1<A> {
| ^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
```
This builds with the MSRV (1.68) and is convenient for creating `static` mutexes. This does bind the implementation to never allocate in `new` in the future, but that seems like a desirable property anyway. Note that this also requires updating slab to 0.4.7, which is the first version that supports const `Slab::new()`.
```
error: unresolved link to `Box`
--> futures-util/src/future/always_ready.rs:43:83
|
43 | /// This is particularly useful in avoiding a heap allocation when an API needs [`Box<dyn Future<Output = T>>`],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `Box` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
= note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
error: unresolved link to `stream.take`
--> futures-util/src/stream/repeat_with.rs:43:7
|
43 | /// [`stream.take()`], in order to make them finite.
| ^^^^^^^^^^^^^ no item named `stream.take` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `stream.repeat`
--> futures-util/src/stream/repeat_with.rs:47:11
|
47 | /// the [`stream.repeat()`] function.
| ^^^^^^^^^^^^^^^ no item named `stream.repeat` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `futures-util::stream::select`
--> futures-util/src/stream/select_with_strategy.rs:120:46
|
120 | /// Note: this special case is provided by [`futures-util::stream::select`].
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `futures-util` in scope
```
taiki-e
added
futures-0.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ready!macro in favor ofstd::task::ready!added in Rust 1.64 (chore: recommend to use core lib's ready macro #2925)pin_mut!macro in favor ofstd::pin::pin!added in Rust 1.68 (chore: reduce dependency to pin-utils #2929)FuturesOrdered::clear(futures ordered: addclearfn #2927)mpsc::*Receiver::recv(channel: Add recv #2947)mpsc::*Receiver::try_recvand deprecatempsc::*Receiver::::try_next(channel: Add try_recv and deprecate try_next #2944)FusedStreamforsink::With(feat: sink::With: FusedStream #2948)no_stdsupport forshared(Support shared futures on no_std #2868)Mutex::new()const (futures-util: makeMutex::new()const #2956)#[clippy::has_significant_drop]to guards (Add#[clippy::has_significant_drop]to guards #2967)pin-utils(chore: reduce dependency to pin-utils #2929)num_cpus(chore: replace num_cpus with available_parallelism #2946)BiLock::lock#2971)Backports:
clearfn #2927read_initializerfeature #2949Mutex::new()const #2956BiLock::lock#2971#[clippy::has_significant_drop]to guards #2967Closes #2988