Add release-plz to use trusted publishing#3027
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Thanks for the PR! However, I suspect release-plz might not work well with futures-rs's release method (which is based on backports using cherry-pick. e.g., #3024)
Also, this repository is not currently creating releases from the main branch.
| - &install-rust | ||
| name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
As ci.yml does, please use taiki-e/install-action instead of these actions. (needed to pass zizmor check in ci/tidy job)
futures-rs/.github/workflows/ci.yml
Lines 62 to 66 in 4fe6c20
rustbot
added
S-waiting-on-author
| # Release unpublished packages. | ||
| release-plz-release: | ||
| name: Release-plz release | ||
| if: ${{ github.repository_owner == 'rust-lang' }} |
There was a problem hiding this comment.
${{ }} is needless in if: .
| if: ${{ github.repository_owner == 'rust-lang' }} | |
| if: github.repository_owner == 'rust-lang' |
| # Create a PR with the new versions and changelog, preparing the next release. | ||
| release-plz-pr: | ||
| name: Release-plz PR | ||
| if: ${{ github.repository_owner == 'rust-lang' }} |
There was a problem hiding this comment.
| if: ${{ github.repository_owner == 'rust-lang' }} | |
| if: github.repository_owner == 'rust-lang' |
|
Sure, happy to change the release method! We can release based on git tags, or GitHub releases, for example. Regarding releasing from |
3 participants
Team PR: rust-lang/team#2594