Merged
Conversation
cuviper
force-pushed
the
rustc_try_insert
branch
from
6ac3bc0 to
1d67359
Compare
This works like `try_insert` but with `RustcOccupiedEntry` in the error case. The error also contains the attempted key as requested in the upstream `try_insert` tracking issue.
cuviper
force-pushed
the
rustc_try_insert
branch
from
1d67359 to
16d0f37
Compare
clarfonthey
reviewed
Apr 20, 2026
Contributor
|
Looks okay to me with one minor comment. Would be cool with you merging after that's fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works like
try_insertbut withRustcOccupiedEntryin the errorcase. The error also contains the attempted key as requested in the
upstream
try_inserttracking issue.