Make Mask::splat const#466
Merged
Merged
Conversation
clarfonthey
force-pushed
the
const-mask-splat
branch
from
June 13, 2025 05:41
e3e7ca5 to
ba7cf0c
Compare
clarfonthey
force-pushed
the
const-mask-splat
branch
from
June 13, 2025 05:42
ba7cf0c to
a857909
Compare
programmerjake
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small step toward making more methods
const.While removing the
Defaultbound was not strictly necessary, I found that it made sense to do given the implementation. Better to mention that it's not used here in the bounds than leave it in.There are probably other mask methods that could be made const with minimal changes, but I didn't want to touch anything that used intrinsics and/or litter everything with
const_eval_selectto make it work.