Release nightly even if the commit is the same#88
Merged
Conversation
It's convenient for people and tools if every nightly exists, as it means people can pin any nightly without thinking. Sometimes, due to CI issues, it can happen that no PR is merged in an entire day. Even then, releasing nightly makes sense, as nightly is intended as a, well, nightly snapshot of master, and if master doesn't change, we can still snapshot it.
It has broken nightly detection and no longer compiles on nightly
Member
Author
|
looks like Ubuntu 24 no longer has an |
Member
|
Please follow https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html to install AWS CLI (downloading the latest zip, extracting it, and calling the install script). |
emilyalbini
approved these changes
May 23, 2025
emilyalbini
left a comment
emilyalbini
left a comment
Member
There was a problem hiding this comment.
Changes look good to me (excluding the broken CI).
Ubuntu 22 no longer works with the GHA setup due to glibc.
/bin/bash does not work on NixOS.
Noratrieb
force-pushed
the
release-every-nightly
branch
from
6e42159 to
7d58aff
Compare
Member
|
You might have to also upgrade the MinIO container we are using to solve the AWS CLI issue. |
Member
Author
|
😭 |
Member
|
The server should be updated too 😅 |
Noratrieb
force-pushed
the
release-every-nightly
branch
from
aea5c7e to
bee181e
Compare
Noratrieb
force-pushed
the
release-every-nightly
branch
from
bee181e to
a36f8d8
Compare
emilyalbini
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's convenient for people and tools if every nightly exists, as it means people can pin any nightly without thinking. Sometimes, due to CI issues, it can happen that no PR is merged in an entire day. Even then, releasing nightly makes sense, as nightly is intended as a, well, nightly snapshot of master, and if master doesn't change, we can still snapshot it.
See https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/nightly-2025-05-15