Install recent AWS CLI in docker and update to Ubuntu 24.04#90
Merged
Conversation
The latest version is required due to the new --if-none-match flag.
Member
|
@Kobzol recently found v2 to be much slower for uploads in the perf collector, we should monitor times after merging this to see if there's a drastic increase. |
Mark-Simulacrum
approved these changes
Jul 2, 2025
Member
Author
I'll make sure to monitor it in the next few days. If it's significantly slower at that point I'd consider moving (at least some of) the AWS interactions to the SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR installs the latest version of AWS CLI directly from AWS, since 22.04 installs v1 and 24.04 doesn't package it at all. We need a recent version because #89 uses the recent
--if-none-matchflag.While I was at it I also bumped the container to Ubuntu 24.04.