feat: guarantee the binary representation of isize explicitly
#2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
AudaciousAxiom
commented
Oct 25, 2025
| r[type.numeric.int.size.isize] | ||
| The `isize` type is a signed integer type with the same number of bits as the | ||
| The `isize` type is a signed two's complement integer type with the same number of bits as the |
There was a problem hiding this comment.
I didn't reflow the paragraph as the policy seems to be to not wrap long lines anymore (which I prefer anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in rust-lang/rust#147960, this adds an explicit guarantee that
isizeis represented with two's complement.This is not intended as a new guarantee, but only as stating what is already mentioned in other places of the reference in the same place as it is for fixed-width integer types:
r? @traviscross