Padding #935
Open
Padding #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a little bit of style cleanup including putting the other half
of the opening of the chapter into a note.
Also a bit of wording change. Removed "today"; Added in some of the
words that were implicit ("properties"), added "targets" after "x64".
Decided to go with the very washy "field or element can be accessed" instead of tring to define a new term for the property since we don't actually define what a field or element is yet.
Havvy
added
A-type-layout
ehuss
reviewed
Feb 8, 2021
Comment on lines
+21
to
+22
| If a field can be accessed, its padding is also the padding of the containing | ||
| type. |
There was a problem hiding this comment.
I'm having a little difficulty understanding this sentence. Can you elaborate on what it is saying? I've always had the impression that padding is the space between fields, not a property of the field itself. And I'm uncertain what "the padding of the containing type" is.
|
☔ The latest upstream changes (possibly bf115a4) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882
There are two initial commits. The first one does some general cleanup while the second actually defines padding. When reviewing, review each commit in order for better understanding.
You can see that while I'm still trying to describe padding as a property of a type, I have to actually say it's a property of a value for padding from fields. Thus I filed #934. Since Size and Alignment also are similarly contorted right now, I don't think figuring what to do about this should block this PR.