Skip to content

feat: ide-assists, Unwrap array #19775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: ide-assists, Unwrap array #19775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
369 changes: 369 additions & 0 deletions crates/ide-assists/src/handlers/unwrap_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,369 @@
use stdx::format_to;
use syntax::{
AstNode, T,
ast::{self, Expr, LiteralKind, Pat, Type, edit::AstNodeEdit, make},
};

use crate::{AssistContext, AssistId, Assists};

// Assist: unwrap_array
//
// Unwrap the array to different variables.
//
// ```
// # //- minicore: result
// fn main() {
// $0let [foo, bar] = ["Foo", "Bar"];
// }
// ```
// ->
// ```
// fn main() {
// let foo = "Foo";
// let bar = "Bar";
// }
// ```
pub(crate) fn unwrap_array(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
let let_kw = ctx.find_token_syntax_at_offset(T![let])?;
let let_node = let_kw.parent()?;
let let_stmt = ast::LetStmt::cast(let_node.clone())?;
let (pat, init) = (let_stmt.pat()?, let_stmt.initializer()?);
let ty = let_stmt.ty();

let Pat::SlicePat(slice_pat) = pat else {
return None;
};
let Expr::ArrayExpr(array_init) = init else {
return None;
};
let arr_ty = ty.and_then(|ty| match ty {
Type::ArrayType(ty) => Some(ty),
_ => None,
});
let arr_ty_len = arr_ty.as_ref().and_then(get_size);
let arr_ty = arr_ty.and_then(|ty| ty.ty());

if slice_pat.pats().count() != array_init.exprs().count()
|| arr_ty_len.is_some_and(|len| len != slice_pat.pats().count())
{
return None;
}

acc.add(
AssistId::refactor_rewrite("unwrap_array"),
"Unwrap array",
let_kw.text_range(),
|builder| {
let mut lets_str = String::new();
let indent = let_stmt.indent_level();

for (pattern, initializer) in slice_pat.pats().zip(array_init.exprs().map(Some)) {
let output = make::let_stmt(pattern, arr_ty.clone(), initializer);
format_to!(lets_str, "{indent}{output}\n");
}

builder.replace(let_node.text_range(), lets_str.trim());
},
)
}

fn get_size(arr: &ast::ArrayType) -> Option<usize> {
match arr.const_arg()?.expr()? {
Expr::Literal(lit) => match lit.kind() {
LiteralKind::IntNumber(num) => num.value().ok().and_then(|n| n.try_into().ok()),
_ => None,
},
_ => None,
}
}

#[cfg(test)]
mod tests {
use crate::tests::{check_assist, check_assist_not_applicable};

use super::*;

#[test]
fn unwrap_arrays() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let [foo, bar] = ["Foo", "Bar"];
}
"#,
r#"
fn main() {
let foo = "Foo";
let bar = "Bar";
}
"#,
);

check_assist(
unwrap_array,
r#"
fn main() {
$0let [foo, bar, baz] = ["Foo", "Bar", "Baz"];
}
"#,
r#"
fn main() {
let foo = "Foo";
let bar = "Bar";
let baz = "Baz";
}
"#,
);
}

#[test]
fn unwrap_array_with_types() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let [foo, bar]: [u8; 2] = [5, 10];
}
"#,
r#"
fn main() {
let foo: u8 = 5;
let bar: u8 = 10;
}
"#,
);
}

#[test]
fn unwrap_array_single_pat() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let [foo]: [u8; 1] = [5];
}
"#,
r#"
fn main() {
let foo: u8 = 5;
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [foo] = [5];
}
"#,
r#"
fn main() {
let foo = 5;
}
"#,
);
}

#[test]
fn unwrap_array_empty() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let []: [u8; 0] = [];//...
}
"#,
r#"
fn main() {
//...
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [] = [];//...
}
"#,
r#"
fn main() {
//...
}
"#,
);
}

#[test]
fn unwrap_array_invalid_len() {
check_assist_not_applicable(
unwrap_array,
r#"
fn main() {
$0let [foo, bar]: [u8; 3] = [5, 10];
}
"#,
);
check_assist_not_applicable(
unwrap_array,
r#"
fn main() {
$0let [foo, bar] = [5, 10, 15];
}
"#,
);
check_assist_not_applicable(
unwrap_array,
r#"
fn main() {
$0let [] = [1];
}
"#,
);
check_assist_not_applicable(
unwrap_array,
r#"
fn main() {
$0let [a] = [];
}
"#,
);
check_assist_not_applicable(
unwrap_array,
r#"
fn main() {
$0let []: [(); 1] = [];
}
"#,
);
}

#[test]
fn unwrap_array_ignore_complex_len() {
check_assist(
unwrap_array,
r#"
const N: usize = 2;
fn main() {
$0let [a, b]: [u8; N] = [2, 3];
}
"#,
r#"
const N: usize = 2;
fn main() {
let a: u8 = 2;
let b: u8 = 3;
}
"#,
);
check_assist(
unwrap_array,
r#"
const N: usize = 3;
fn main() {
$0let [a, b]: [u8; N] = [2, 3];
}
"#,
r#"
const N: usize = 3;
fn main() {
let a: u8 = 2;
let b: u8 = 3;
}
"#,
);
}

#[test]
fn unwrap_array_with_empty_len() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let [a, b]: [u8;] = [2, 3];
}
"#,
r#"
fn main() {
let a: u8 = 2;
let b: u8 = 3;
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [a, b]: [u8; _] = [2, 3];
}
"#,
r#"
fn main() {
let a: u8 = 2;
let b: u8 = 3;
}
"#,
);
}

#[test]
fn unwrap_array_with_complex_pattern() {
check_assist(
unwrap_array,
r#"
fn main() {
$0let [a | a, b @ c]: [u8; 2] = [2, 3];
}
"#,
r#"
fn main() {
let a | a: u8 = 2;
let b @ c: u8 = 3;
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [a | a, b @ c] = [2, 3];
}
"#,
r#"
fn main() {
let a | a = 2;
let b @ c = 3;
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [m @ (a | a), b @ c] = [2, 3];
}
"#,
r#"
fn main() {
let m @ (a | a) = 2;
let b @ c = 3;
}
"#,
);
check_assist(
unwrap_array,
r#"
fn main() {
$0let [_, b @ c] = [2, 3];
}
"#,
r#"
fn main() {
let _ = 2;
let b @ c = 3;
}
"#,
);
}
}
2 changes: 2 additions & 0 deletions crates/ide-assists/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ mod handlers {
mod unmerge_match_arm;
mod unnecessary_async;
mod unqualify_method_call;
mod unwrap_array;
mod unwrap_block;
mod unwrap_return_type;
mod unwrap_tuple;
Expand Down Expand Up @@ -370,6 +371,7 @@ mod handlers {
unwrap_block::unwrap_block,
unwrap_return_type::unwrap_return_type,
unwrap_tuple::unwrap_tuple,
unwrap_array::unwrap_array,
unwrap_type_to_generic_arg::unwrap_type_to_generic_arg,
wrap_return_type::wrap_return_type,
wrap_unwrap_cfg_attr::wrap_unwrap_cfg_attr,
Expand Down
Loading