fix: Auto completion should use fully qualified syntax in case of ambiguity #18895 #21306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asukaminato0721
force-pushed
the
18895
branch
from
1fbac0e to
0456716
Compare
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Pull request overview
This PR fixes auto-completion for trait methods accessed via type paths (e.g., Dog::). When a trait method is completed through a type qualifier, the completion now automatically rewrites it to use Universal Function Call Syntax (UFCS) in the form <Type as Trait>::method() to resolve ambiguity.
Key changes:
- Added UFCS detection and rewriting logic for trait method completions
- Extended call parentheses insertion to support qualified syntax with customizable replacement ranges
- Added regression test ensuring
Dog::baby_namecompletes to<Dog as Animal>::baby_name()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/ide-completion/src/tests/expression.rs | Added regression test for UFCS syntax in trait method completion |
| crates/ide-completion/src/render/function.rs | Implemented UFCS detection, rewriting logic, and helper utilities for qualified trait method completion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Update crates/ide-completion/src/render/function.rs Co-authored-by: Copilot <[email protected]> clippy
asukaminato0721
force-pushed
the
18895
branch
from
ea4b0af to
a4d805a
Compare
Veykril
changed the title
Veykril
reviewed
Dec 21, 2025
Member
Veykril
left a comment
Veykril
left a comment
There was a problem hiding this comment.
We shouldn't fully qualify calls unless its necessary as outlined in the issue. The implementation here just always qualifies it which isn't quite what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18895
Updated the completion renderer to detect when a trait method is being completed via a type path and rewrite the edit to the UFCS form (
<Ty as Trait>::method) before emitting the completion item, including the new UfcsData/CallSnippetRewrite plumbing and trait-container detection in render_fn so both plain inserts and call-paren snippets respect the wider replacement range.Extended add_call_parens to accept the optional rewrite data, build snippets using the qualified call head, and emit a TextEdit that spans the entire qualifier when necessary.
Added helper utilities to compute the qualifier text/range, render the trait path, and decide when UFCS rewriting is appropriate so the logic stays isolated and testable.
Added a regression test that exercises completing Dog:: when only a trait implementation exists to ensure the completion now expands to
<Dog as Animal>::baby_name().