Fix nested edits in SyntaxEditor#22269
Open
Shourya742 wants to merge 3 commits intorust-lang:masterfrom
Open
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
May 4, 2026
Comment on lines
+114
to
+117
| .rev() | ||
| .position(|ancestor| ancestor.affected_range().contains_range(change.target_range())) | ||
| { | ||
| let index = changed_ancestors.len() - 1 - index; |
Contributor
There was a problem hiding this comment.
Suggested change
| .rev() | |
| .position(|ancestor| ancestor.affected_range().contains_range(change.target_range())) | |
| { | |
| let index = changed_ancestors.len() - 1 - index; | |
| .enumerate() | |
| .rev() | |
| .find(|ancestor| ancestor.affected_range().contains_range(change.target_range())) | |
| { |
Clearer this way.
Member
Author
There was a problem hiding this comment.
Used rposition, since we can’t use the ancestor from enumerate directly, we need a mutable reference to changed_ancestors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285