Simplify Rust to Clang target conversion #2808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the spirit of this PR as the current code has been pretty much a "oh damn, this other target doesn't work, let me get some tape" kind of situation, It also makes me think that we should have some dedicated type for the target triples. So instead of doing Maybe using https://docs.rs/target-lexicon would be a good idea. It is an extra dependency, but it doesn't have other dependencies and it is well maintained IMHO. |
emilio
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies/generalizes the rust to clang target conversion and allows more targets to work. (e.g.
riscv32i-unknown-none-elf)Let me know if I'm missing something!