Change Bindings::write() to take impl Write instead of &mut dyn Write
#3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Write` Dynamic dispatch is not (always) needed here, and this way an owned `File` can trivially be moved into the function again like before without forcing a mutable borrow. Noting that `Write` is even implemented on `&File`, which can now be more easily passed without having it under `mut`.
emilio
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed immediately after #3317 was merged:
Dynamic dispatch is not (always) needed here, and this way an owned
Filecan trivially be moved into the function again like before without forcing a mutable borrow. Noting thatWriteis even implemented on&File, which can now be more easily passed without having it undermut.