Skip to content

Conversation

@Skgland
Copy link
Contributor

@Skgland Skgland commented Dec 15, 2025

An attempt to resolve #3152

Treats 1.X.Y-beta[.Z] as complete (same as 1.X.Y) and 1.X.Y-nighty as incomplete (same as 1.X-1.MAX).

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. FWIW I think you might need to reformat using nightly rustfmt (sorry, this is long-standing rust-lang/rustfmt#5549 and co, but I guess at this point just removing that option from rustfmt config is better)

@Skgland
Copy link
Contributor Author

Skgland commented Dec 15, 2025

Sounds good. FWIW I think you might need to reformat using nightly rustfmt (sorry, this is long-standing rust-lang/rustfmt#5549 and co, but I guess at this point just removing that option from rustfmt config is better)

Yeah, I just notices a couple of minutes ago that CI failed.
Though I am having a problem getting nightly rustfmt to work.

PS F:\Git\rust-bindgen> cargo +nightly fmt
Der Dateiname oder die Erweiterung ist zu lang. (os error 206)
This utility formats all bin and lib files of the current crate using rustfmt.

Usage: cargo fmt [OPTIONS] [-- <rustfmt_options>...]

Arguments:
  [rustfmt_options]...  Options passed to rustfmt

Options:
  -q, --quiet
          No output printed to stdout
  -v, --verbose
          Use verbose output
      --version
          Print rustfmt version and exit
  -p, --package <package>...
          Specify package to format
      --manifest-path <manifest-path>
          Specify path to Cargo.toml
      --message-format <message-format>
          Specify message-format: short|json|human
      --all
          Format all packages, and also their local path-based dependencies
      --check
          Run rustfmt in check mode
  -h, --help
          Print help

@Skgland
Copy link
Contributor Author

Skgland commented Dec 15, 2025

Running cargo +nightly fmt under WSL2 Ubuntu worked.

@emilio
Copy link
Contributor

emilio commented Dec 16, 2025

Could you squash the commits please? Thank you :)

@Skgland
Copy link
Contributor Author

Skgland commented Dec 16, 2025

Could you squash the commits please? Thank you :)

Done

@emilio emilio added this pull request to the merge queue Dec 16, 2025
Merged via the queue into rust-lang:main with commit 23e2b01 Dec 16, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--rust-target beta and nightly suffixes

2 participants