Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial impl of repr_packed_without_abi #13398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukaslueg
Copy link
Contributor

Fixes #13375

I've added the lint next to the other attribute-related ones. Not sure if this is the correct place, since while we are looking after the packed-attribute (there is nothing we can do about types defined elsewhere), we are more concerned about the type's representation set by the attribute (instead of "duplicate attributes" and such).

The lint simply looks at the attributes themselves without concern for the item-kind, since items where repr is not allowed end up in a compile-error anyway.

I'm somewhat concerned about the level of noise this lint would cause if/when it goes into stable, although it does not come up in lintcheck.

changelog: [`repr_packed_without_abi`]: Initial implementation

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 15, 2024
@bors
Copy link
Collaborator

bors commented Oct 1, 2024

☔ The latest upstream changes (presumably #13286) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lint: repr(packed) without ABI qualification
4 participants