Skip to content

Implement a ReturnVisitor #13557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement a ReturnVisitor #13557

wants to merge 1 commit into from

Conversation

GnomedDev
Copy link
Contributor

@GnomedDev GnomedDev commented Oct 16, 2024 •
edited
Loading

Closes #13552

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2024
@GnomedDev
Copy link
Contributor Author

This is now generic enough for the never returns lint, so ready for review!

@GnomedDev GnomedDev marked this pull request as ready for review October 19, 2024 00:35
@GnomedDev GnomedDev mentioned this pull request Oct 19, 2024
Draft
dswij
dswij approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! can we squash some commits?

@GnomedDev
Copy link
Contributor Author

Done @dswij!

@bors
Copy link
Contributor

bors commented Oct 21, 2024

☔ The latest upstream changes (presumably #13567) made this pull request unmergeable. Please resolve the merge conflicts.

@GnomedDev GnomedDev mentioned this pull request Nov 5, 2024
Draft
@Jarcho
Copy link
Contributor

Jarcho commented Nov 15, 2024

Ping @dswij from triage. Looks like you were ready to merge this.

@Jarcho
Copy link
Contributor

Jarcho commented Dec 6, 2024

r? @Jarcho

Taking over since @dswij seems to be busy.

This visitor seems to conflate two things which shouldn't be mixed together. A combination of places the code returns from and the values it returns.

For unnecessary_literal_bound, only the returned values are needed. This doesn't walk the any explicit return expressions so this isn't really sufficient as is.

For #13565 this is overly complicated. There you only need to check, for all explicit returns and the implicit return, if the value is of type ! or it's a block where the final expression meets the same conditions.

@rustbot rustbot assigned Jarcho and unassigned dswij Dec 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal utility for visiting all returns
5 participants
@GnomedDev @rustbot @bors @Jarcho @dswij