Test that all interned symbols are referenced in Clippy sources #14842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
symbols-used
branch
from
f387524 to
76de08b
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
symbols-used
branch
from
76de08b to
f345950
Compare
|
Rebased |
Alexendoo
reviewed
May 20, 2025
tests/symbols-used.rs
Outdated
Comment on lines
7
to
10
| // This test only runs when the `internal` feature is set, to allow | ||
| // developers to temporarily define new, yet unused symbols without | ||
| // failing the tests. Also, the test is a no-op if run as part of the | ||
| // compiler test suite. |
There was a problem hiding this comment.
IMO ditch the cfg, it's surprising that a test that doesn't require internals gets skipped without it
tests/symbols-used.rs
Outdated
Comment on lines
51
to
49
| #[tokio::test] | ||
| #[allow(clippy::case_sensitive_file_extension_comparisons)] | ||
| async fn all_symbols_are_used() -> Result<()> { |
There was a problem hiding this comment.
Since we're just using tokio for its threadpool here perhaps used_symbols should use rayon instead, the other things can run serially
There was a problem hiding this comment.
Ok, I was reluctant to add rayon as a new dependency, I'll make the change.
samueltardieu
force-pushed
the
symbols-used
branch
from
f345950 to
eb03af0
Compare
samueltardieu
force-pushed
the
symbols-used
branch
from
eb03af0 to
5ee0480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks that all symbols defined in Clippy's
sym.rsfile are used in Clippy. Otherwise, it will fail with a list of symbols which are unused.This test only runs when the
internalfeature is set, to allow developers to temporarily define new, yet unused symbols without failing the tests. Also, it will not run as part of the compiler test suite, as an extra symbol should never be seen as a fatal problem in the compiler repo.changelog: none