Skip to content

Add allow-invalid configuration option for disallowed_* to the documentation #14845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add allow-invalid configuration option for disallowed_* to the documentation #14845

wants to merge 1 commit into from

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented May 19, 2025 •
edited by rustbot
Loading

Close #14836

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 19, 2025
@alex-semenyuk alex-semenyuk marked this pull request as draft May 19, 2025 07:58
@alex-semenyuk alex-semenyuk changed the title Add allow-invalid configuration option for disallowed_* to the documentation [WIP] Add allow-invalid configuration option for disallowed_* to the documentation May 19, 2025
@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 6 times, most recently from c84f1f9 to 9b3dcd2 Compare May 19, 2025 08:48
@alex-semenyuk alex-semenyuk changed the title [WIP] Add allow-invalid configuration option for disallowed_* to the documentation Add allow-invalid configuration option for disallowed_* to the documentation May 19, 2025
@alex-semenyuk alex-semenyuk marked this pull request as ready for review May 19, 2025 08:53
@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 4 times, most recently from 3ba020f to 4524d7d Compare May 19, 2025 21:08
samueltardieu
samueltardieu reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some nitpicking about the formatting.

@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 3 times, most recently from 234c3e3 to 9cb8856 Compare May 19, 2025 21:33
samueltardieu
samueltardieu reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more formatting nitpicking, otherwise it looks good to me. I'll let @flip1995 have the final word though.

@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch from 9cb8856 to 0bac1ca Compare May 20, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow-invalid configuration option for disallowed_* is missing from the documentation
4 participants
@alex-semenyuk @rustbot @samueltardieu @flip1995