-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(empty_drop): rename to empty_drops
#15977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Lintcheck changes for 7b9751c
This comment will be updated if you push new changes |
|
Why not discuss this in Zulip and propose to rename all misnamed lints at once? Having some lints renamed and some others suffering from the same problem not renamed is confusing. |
|
I was thinking that it would be easier to review many smaller PRs than one big one, but yeah your proposal does sound better. Though if we do go with one big PR, I'd really hope that that it would then get merged ASAP, since keeping it up-to-date with master would be a nightmare.. I'll open a thread on Zulip then (though not right away, a bit busy rn) |
|
If the discussion is favorable, you may as well extend this PR. @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
☔ The latest upstream changes (possibly c48592e) made this pull request unmergeable. Please resolve the merge conflicts. |
Lint names should be in plural
changelog: [
empty_drop]: rename toempty_drops