Fix question_mark suggests wrongly when match scrutinee is a reference type#17431
Open
profetia wants to merge 1 commit into
Open
Fix question_mark suggests wrongly when match scrutinee is a reference type#17431profetia wants to merge 1 commit into
question_mark suggests wrongly when match scrutinee is a reference type#17431profetia wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
Gri-ffin
reviewed
Jul 21, 2026
| Some(it) => it, | ||
| None => return None, | ||
| }; | ||
| // `match &v` still produces `&v?`, unchanged |
Contributor
There was a problem hiding this comment.
Wouldn't this cause an error if it's used after the match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17386
question_marksuggests wrongly whenmatchscrutinee is a reference type like&Option<T>, since?is not implemented on references.changelog: [
question_mark] fix wrong suggestions whenmatchscrutinee is a reference type.