Move driver tests to an actual test - #17576
Conversation
rustbot
added
the
S-waiting-on-community-reviews
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
| ./target/debug/clippy-driver -Dwarnings -Aunused -Zui-testing --emit metadata --crate-type bin tests/ui/char_lit_as_u8.rs 2>char_lit_as_u8.stderr && exit 1 | ||
| sed -e "/= help: for/d" char_lit_as_u8.stderr > normalized.stderr | ||
| diff -u normalized.stderr tests/ui/char_lit_as_u8.stderr |
There was a problem hiding this comment.
This isn't copied over, but I don't really know what this is testing. compile-test already calls the driver directly and it already succeeded.
| CLIPPY=$(./target/debug/clippy-driver ./target/driver_test.rs --rustc) | ||
| RUSTC=$(rustc ./target/driver_test.rs) | ||
| diff -u <($CLIPPY) <($RUSTC) |
There was a problem hiding this comment.
Same thing here. This is only testing that both commands have no output, but clippy-driver without --rustc would also output nothing.
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
3 participants
cc @flip1995
changelog: none