Skip to content

Enhance go-to-position for the simple and Monaco editors #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

shepmaster
Copy link
Member

No description provided.

We already use object identity for this prop with Ace (and Redux helps
us keep it stable) and this allows a person to click the link a second
time and get the code re-selected. Since the prop doesn't change
value, the second click does nothing with a value-based test.
@shepmaster shepmaster added bug The playground isn't doing what it was intended to enhancement Something new the playground could do labels Feb 10, 2025
@shepmaster shepmaster merged commit 87a7451 into main Feb 10, 2025
17 checks passed
@shepmaster shepmaster deleted the editor-goto-line branch February 10, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The playground isn't doing what it was intended to enhancement Something new the playground could do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant