-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do partial SsaLocals analysis in unoptimized builds #134051
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Do partial SsaLocals analysis in unoptimized builds I've been musing about the perf implications of all the queries that `is_freeze` results in. Let's perf it. CI will fail because I'm too lazy to figure out what's going on with the mir-opt tests for now. If perf looks bad, it's not worth fixing the tests. (it's not like this makes GVN lightweight or light on queries overall, because evaluating consts is still quite a lot of queries) r? ghost
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (46ae8eb): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.1%, secondary -14.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.0%, secondary -8.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.5%, secondary -4.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 766.815s -> 768.247s (0.19%) |
Interesting. Looks like this removes ~98% of the LLVM time for deep-vector. Also it looks for incr-unchanged and incr-patched builds we have a handful of improvements and no regressions, but for full and incr-full builds we're almost all regressions. The self-profile breakdown points to GVN as the culprit (of course) except for the image debug-full build where the regression is... in LLVM??? image debug-full is also the largest binary size regression which corroborates that. How strange. |
696799b
to
a0353d5
Compare
This comment has been minimized.
This comment has been minimized.
a0353d5
to
a013042
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Do partial SsaLocals analysis in unoptimized builds I've been musing about the perf implications of all the queries that `is_freeze` results in. (it's not like this makes GVN lightweight or light on queries overall, because evaluating consts is still quite a lot of queries)
This comment has been minimized.
This comment has been minimized.
f73cd00
to
04cc82e
Compare
This comment has been minimized.
This comment has been minimized.
04cc82e
to
5d55fae
Compare
This comment has been minimized.
This comment has been minimized.
5d55fae
to
f797c92
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Do partial SsaLocals analysis in unoptimized builds I've been musing about the perf implications of all the queries that `is_freeze` results in. (it's not like this makes GVN lightweight or light on queries overall, because evaluating consts is still quite a lot of queries)
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b14fa64): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.7%, secondary -3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.4%, secondary -1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 790.529s -> 790.638s (0.01%) |
1580046
to
ffee3ac
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
I've been musing about the perf implications of all the queries that
is_freeze
results in.(it's not like this makes GVN lightweight or light on queries overall, because evaluating consts is still quite a lot of queries)