-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] perf run for rustc-hash candidate (folded multiply) #136095
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in exhaustiveness checking cc @Nadrieril |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…, r=<try> [DO NOT MERGE] perf run for rustc-hash candidate (folded multiply) See rust-lang/rustc-hash#55.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…, r=<try> [DO NOT MERGE] perf run for rustc-hash candidate (folded multiply) See rust-lang/rustc-hash#55.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
this should also allow you to do your own try builds (but not perf I think) |
This comment has been minimized.
This comment has been minimized.
✌️ @orlp, you can now approve this pull request! If @Noratrieb told you to " |
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [DO NOT MERGE] from this PR's title when it is ready for review. |
sorry bors it looks like you're not up to the task |
…, r=<try> [DO NOT MERGE] perf run for rustc-hash candidate (folded multiply) See rust-lang/rustc-hash#55.
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (d694429): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.6%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.4%, secondary 2.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 774.799s -> 773.882s (-0.12%) |
I wonder if the refactor to As far as I understand, the idea behind the But what if the initial 0 * K isn’t actually free? And/or the difference of order in I suppose, we can test the performance of a variant of this change, where the new |
…-changed-ordering-perf, r=<try> [DO NOT MERGE] perf run for only mul/add-reordering parts of rust-lang#136095 See rust-lang#136095 (comment) --- *For good comparability with the performance of rust-lang#136095, I'm keeping the `rustc-hasher` in `rustc_type_ir` at the "newly modified 2.*"… just noting this down in case it might be a difference from master that matters much.* --- ([link to the `rustc-hash` commits for context](rust-lang/rustc-hash@43e1790...1028035))
See rust-lang/rustc-hash#55.