Mark some std tests as requiring panic = "unwind"
#138294
Open
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Mar 10, 2025
library/std/src/thread/tests.rs
Outdated
| @@ -63,6 +63,7 @@ fn test_named_thread_truncation() { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg_attr(not(panic = "unwind"), ignore = "test requires unwinding support")] | |||
| #[should_panic] | |||
| fn test_invalid_named_thread() { | |||
| let _ = Builder::new().name("ada l\0velace".to_string()).spawn(|| {}); | |||
There was a problem hiding this comment.
This test doesn't need unwinding support. -Zpanic-abort-tests supports it just fine too. And without -Zpanic-abort-tests, #[should_panic] tests should be skipped for panic=abort already.
There was a problem hiding this comment.
OK, I removed this one.
This allows these test modules to pass on builds/targets without unwinding support, where `panic = "abort"` - the ignored tests are for functionality that's not supported on those targets.
paulmenage
force-pushed
the
test-panic-unwind
branch
from
1f97da3 to
9e5c942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows these test modules to pass on builds/targets without unwinding support, where
panic = "abort"- the ignored tests are for functionality that's not supported on those targets.