Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unsized tuple impls now that we don't support unsizing tuples anymore #138340

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove some unsized tuple impls now that we don't support unsizing tuples anymore #138340

wants to merge 1 commit into from
+4 −28

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 11, 2025 •
edited
Loading

Since #137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: #138093) due to people using PhantomData<(T, U)> where U: ?Sized (they'd have to use (PhantomData<T>, PhantomData<U>) now), we can remove the impls from libcore I believe.

r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 11, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 11, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#138340 - oli-obk:one-size-fits-all, r=<try>
0fe3684 
Remove some unsized tuple impls now that we don't support unsizing tuples anymore

Since rust-lang#137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language due to people using `PhantomData<(T, U)>` where `U: ?Sized` (they'd have to use `(PhantomData<T>, PhantomData<U>)` now), we can remove the impls from libcore I believe.

r? ghost
@bors
Copy link
Contributor

bors commented Mar 11, 2025

⌛ Trying commit 93f64c5 with merge 0fe3684...

@bors
Copy link
Contributor

bors commented Mar 11, 2025

☀️ Try build successful - checks-actions
Build commit: 0fe3684 (0fe3684930279e4d3be3aca66b30f82946ce9ac2)

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 11, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-138340 created and queued.
🤖 Automatically detected try build 0fe3684
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-138340 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-138340 is completed!
📊 27 regressed and 1 fixed (596183 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 12, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 12, 2025

The only regression is https://crates.io/crates/ord_subset/3.1.1 which was last updated 6 years ago. I'll check if I can contract the author, as there are a few crates depending on it

@oli-obk oli-obk mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @bors @craterbot @rustbot