-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some unsized tuple impls now that we don't support unsizing tuples anymore #138340
base: master
Are you sure you want to change the base?
Conversation
@bors try |
Remove some unsized tuple impls now that we don't support unsizing tuples anymore Since rust-lang#137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language due to people using `PhantomData<(T, U)>` where `U: ?Sized` (they'd have to use `(PhantomData<T>, PhantomData<U>)` now), we can remove the impls from libcore I believe. r? ghost
☀️ Try build successful - checks-actions |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
The only regression is https://crates.io/crates/ord_subset/3.1.1 which was last updated 6 years ago. I'll check if I can contract the author, as there are a few crates depending on it |
Since #137728 there is no sound way to create unsized tuples anymore. While we can't remove them from the language (tried here: #138093) due to people using
PhantomData<(T, U)>
whereU: ?Sized
(they'd have to use(PhantomData<T>, PhantomData<U>)
now), we can remove the impls from libcore I believe.r? ghost