checktools.sh: fix bashism #140917
Open
checktools.sh: fix bashism #140917
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
why do we even have /bin/sh shebangs, we could be free from this suffering with a little bit of /usr/bin/env bash |
|
Yeah probably, but that felt like a bigger change.^^ |
|
All right, this time the tests actually got tested, and it took 54s. I assume that's okay in terms of CI time, but Cc @rust-lang/infra anyway for good measure. |
|
Yeah that's fine. |
WaffleLapkin
approved these changes
May 16, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #140903. Turns out
tests/{pass,panic}only properly expands in bash, not in dash. :/r? @WaffleLapkin