[win] Use a dash instead of slash for linker to avoid breaking lld #140977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
r? @jieyouxu (Sorry, referenced the wrong PR as causing the regression) |
|
r? jieyouxu @bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2025
[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry (not enough space) |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
May 14, 2025
[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2025
Rollup of 4 pull requests Successful merges: - rust-lang#140953 (Fix a compiletest blessing message) - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap) - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items) - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld) r? `@ghost` `@rustbot` modify labels: rollup
For a value of "fix" that means lld emitting a warning about an unknown argument. |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 15, 2025
[win] Use a dash instead of slash for linker to avoid breaking lld rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files. Fix is to use a dash for the arg: `-arm64hazardfree` r? `@wesleywiser`
Unfortunately, #133409 forced the lld and non-lld args to be the same, and there doesn't seem to be a standard way to indicate that an argument is intentionally different between the two. @RalfJung @petrochenkov what's the correct way to add an MSVC linker ONLY arg that SHOULDN'T be passed to lld? |
|
Nevermind, the more that I think about this, the more that I believe that using the undocumented flag is the incorrect solution. I'm going to disable the test instead, and I've filed a bug against the MSVC team to remove this check from the linker: https://developercommunity.microsoft.com/t/Remove-checking-for-and-fixing-Cortex-A/10905134 |
|
Abandoning in favor of #141045 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2025
…mpiler-errors Rollup of 14 pull requests Successful merges: - rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary") - rust-lang#140130 (Add LLDB providers for BTreeMap and BTreeSet) - rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`) - rust-lang#140712 (normalization: avoid incompletely constraining GAT args) - rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output) - rust-lang#140834 (move (or remove) some impl Trait tests) - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at) - rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld) - rust-lang#140990 (VxWorks: updates from recent libc versions) - rust-lang#141003 (Improve ternary operator recovery) - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows) - rust-lang#141026 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#140758 added the
/arm64hazardfreelinker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking withlldas it 1) doesn't understand the arguments and 2) assumes that unknown args that start with/are input files.Fix is to use a dash for the arg:
-arm64hazardfreer? @wesleywiser