Skip to content

Lexer: check in advance_token to avoid regard spare ## as GardedStrPrefix #141028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lexer: check in advance_token to avoid regard spare ## as GardedStrPrefix #141028

wants to merge 2 commits into from
+120 −14

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented May 15, 2025 •
edited
Loading

Fixes #140618

I performed additional checks to avoid treating the two ## after r#‘xxx’#### as GardedStrPrefix.

GardedStrPrefix is introduced in 321a5db.

r? compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2025
@xizheyin
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 15, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@xizheyin xizheyin changed the title Lexer: check ### to avoid regard ## as GardedStrPrefix Lexer: check in advance_token to avoid regard spare ## as GardedStrPrefix May 15, 2025
@xizheyin
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raw strings w/ too many terminating hashes are not exclusively handled
4 participants
@xizheyin @rustbot @rust-log-analyzer @BoxyUwU