Do not emit help when shorthand from macro when suggest ? or expect
#141070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
chenyukang
reviewed
May 16, 2025
|
r? chenyukang (since you're already looking at it, but I can take the review back if you're busy) |
jieyouxu
reviewed
May 16, 2025
chenyukang
reviewed
May 16, 2025
Signed-off-by: xizheyin <[email protected]>
…ypeck/ to it Signed-off-by: xizheyin <[email protected]>
xizheyin
commented
May 16, 2025
Comment on lines
+47
to
+48
|
|
||
| for_each_operator!(translate) |
There was a problem hiding this comment.
I delete the unused comment.
There was a problem hiding this comment.
I create tests/ui/typeck/suggestions/ amd move some testcases to it.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 17, 2025
Do not emit help when shorthand from macro when suggest `?` or `expect` Fixes rust-lang#140659 I didn't fully minimize the original bug, but I found a similar test case, and they have perhaps the same root cause. For the bug mentioned in rust-lang#140659 , I also tested it locally and passed it. Jieyou has worked on this part before, maybe r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140659
I didn't fully minimize the original bug, but I found a similar test case, and they have perhaps the same root cause. For the bug mentioned in #140659 , I also tested it locally and passed it.
Jieyou has worked on this part before, maybe r? @jieyouxu