Skip to content

use if matches! instead of match for simplicity #141106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GrantBirki
Copy link

This pull request updates the check.rs + assert.rs files to use matches! instead of match for simplicity. This change makes it a bit easier to read without changing any core functionality.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

@RalfJung
Copy link
Member

RalfJung commented May 17, 2025 via email

@lcnr
Copy link
Contributor

lcnr commented May 17, 2025

I agree with @RalfJung that this worsens readability. Even if others consider this change to be neutral, it would not be worth the churn.

Thank you for your contribution and we'd be happy to review more substantial changes in the future

@lcnr lcnr closed this May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants