Avoid a gratuitous 10s wait in a stress test #142224
Merged
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
`stress_recv_timeout_two_threads`, in the mpmc and mpsc testsuites, is a stress test of the `recv_timeout` function. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred. The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the *total* runtime of the `library/std` testsuite. Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s. Add a check that at least one timeout occurred.
joshtriplett
force-pushed
the
remove-gratuitous-wait-in-stress-test
branch
from
e363076 to
889f7cb
Compare
|
The biggest concern I have with this PR is possibly being really slow on certain CI jobs, so let's give it a whirl on those platforms. |
|
@bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 9, 2025
…-test, r=<try> Avoid a gratuitous 10s wait in a stress test `stress_recv_timeout_two_threads`, in the mpmc and mpsc testsuites, is a stress test of the `recv_timeout` function. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred. The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the *total* runtime of the `library/std` testsuite, and is the only standard library test that takes more than a second. Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s. Add a check that at least one timeout occurred. try-job: test-various try-job: i686-gnu-1 try-job: i686-gnu-nopt-1 try-job: i686-gnu-nopt-2 try-job: i686-msvc-1 try-job: armhf-gnu try-job: arm-android try-job: aarch64-gnu-debug try-job: x86_64-gnu-debug
|
💔 Test failed
|
|
That's... weird. @joshtriplett Can you try rebasing this on latest and rerunning the try-jobs? |
|
@workingjubilee It's already based on the latest HEAD. As far as I can tell, the try failures look spurious? |
|
huh. Let's give it another go. @bors2 try |
rust-bors bot
added a commit
that referenced
this pull request
Jun 9, 2025
…-test, r=<try> Avoid a gratuitous 10s wait in a stress test `stress_recv_timeout_two_threads`, in the mpmc and mpsc testsuites, is a stress test of the `recv_timeout` function. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred. The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the *total* runtime of the `library/std` testsuite, and is the only standard library test that takes more than a second. Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s. Add a check that at least one timeout occurred. try-job: test-various try-job: i686-gnu-1 try-job: i686-gnu-nopt-1 try-job: i686-gnu-nopt-2 try-job: i686-msvc-1 try-job: armhf-gnu try-job: arm-android try-job: aarch64-gnu-debug try-job: x86_64-gnu-debug
|
💔 Test failed
|
|
...no, I don't believe this PR can be causing failures in run-make jobs, but also this test suite really ought to be passing. |
|
@bors try |
bors
added a commit
that referenced
this pull request
Jun 9, 2025
…-test, r=<try> Avoid a gratuitous 10s wait in a stress test `stress_recv_timeout_two_threads`, in the mpmc and mpsc testsuites, is a stress test of the `recv_timeout` function. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred. The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the *total* runtime of the `library/std` testsuite, and is the only standard library test that takes more than a second. Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s. Add a check that at least one timeout occurred. try-job: test-various try-job: i686-gnu-1 try-job: i686-gnu-nopt-1 try-job: i686-gnu-nopt-2 try-job: i686-msvc-1 try-job: armhf-gnu try-job: arm-android try-job: aarch64-gnu-debug try-job: x86_64-gnu-debug
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
Well, at least it doesn't seem to be a bors2 issue. Definitely looks spurious though. |
|
@bors r+ into your hands, I commend my spirit |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup of 6 pull requests Successful merges: - #141751 (Remap compiler vs non-compiler sources differently (bootstrap side)) - #142160 (Only allow `bootstrap` cfg in rustc & related) - #142191 (early return in trait detection for non-trait item) - #142211 (Do not checkout GCC submodule for the tidy job) - #142218 (CI: rfl: move job forward to Linux v6.16-rc1) - #142224 (Avoid a gratuitous 10s wait in a stress test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup merge of #142224 - joshtriplett:remove-gratuitous-wait-in-stress-test, r=workingjubilee Avoid a gratuitous 10s wait in a stress test `stress_recv_timeout_two_threads`, in the mpmc and mpsc testsuites, is a stress test of the `recv_timeout` function. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred. The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the *total* runtime of the `library/std` testsuite, and is the only standard library test that takes more than a second. Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s. Add a check that at least one timeout occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stress_recv_timeout_two_threads, in the mpmc and mpsc testsuites, is a stress test of therecv_timeoutfunction. This test processes and ignores timeouts, and just ensures that every sent value gets received. As such, the exact length of the timeouts is not critical, only that the timeout and sleep durations ensure that at least one timeout occurred.The current tests have 100 iterations, half of which sleep for 200ms, causing the test to take 10s. This represents around 2/3rds of the total runtime of the
library/stdtestsuite, and is the only standard library test that takes more than a second.Reduce this to 50 iterations where half of them sleep for 10ms, causing the test to take 0.25s.
Add a check that at least one timeout occurred.