Assorted bootstrap cleanups (step 1) #142303
Merged
+381
−353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-testsuite
|
This PR modifies If appropriate, please update This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp. This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
This comment has been minimized.
This comment has been minimized.
Host is the machine where bootstrap runs, and this field represents the target of the (host) stage0/beta compiler. This is much clearer than `build`, which also conflicts with the `Build` struct, which is stored under the name `build` inside `Builder` (lol).
…uild_compiler` in a few places
Kobzol
force-pushed
the
bootstrap-cleanup-1
branch
from
86fb1c0 to
20e8325
Compare
jieyouxu
reviewed
Jun 10, 2025
jieyouxu
approved these changes
Jun 11, 2025
|
I'm still not super sure about the @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 12, 2025
Rollup of 10 pull requests Successful merges: - #141307 (Add method to retrieve body of closure in stable-mir) - #142040 (transmutability: shift abstraction boundary) - #142066 (More simple 2015 edition test decoupling) - #142157 (rustc_resolve: Improve `resolve_const_param_in_non_trivial_anon_const` wording) - #142217 (`tests/ui`: A New Order [10/N]) - #142219 (`tests/ui`: A New Order [11/N]) - #142261 (use correct edition when warning for unsafe attributes) - #142303 (Assorted bootstrap cleanups (step 1)) - #142318 (Cleanup `rust-src` remapping and real dir) - #142352 (compiler: Make `c_int_width` an integer) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 12, 2025
Rollup merge of #142303 - Kobzol:bootstrap-cleanup-1, r=jieyouxu Assorted bootstrap cleanups (step 1) Now that the stage0 redesign has landed, we can finally start cleaning up many things in bootstrap, and lord knows it deserves it! I plan to send many PRs once I figure out an incremental way forward, this is the first one of them. It doesn't actually change anything, just renames stuff and adds more documentation, but the rename is bitrotty, so I wanted to push the PR eagerly. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the stage0 redesign has landed, we can finally start cleaning up many things in bootstrap, and lord knows it deserves it! I plan to send many PRs once I figure out an incremental way forward, this is the first one of them. It doesn't actually change anything, just renames stuff and adds more documentation, but the rename is bitrotty, so I wanted to push the PR eagerly.
r? @jieyouxu