Skip to content

tests: Add RUST_BACKTRACE and -Cpanic revisions to panic-main.rs test #142304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

tests: Add RUST_BACKTRACE and -Cpanic revisions to panic-main.rs test #142304

wants to merge 4 commits into from

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jun 10, 2025 •
edited
Loading

This is a regression test for #123733 (P-high and regression-from-stable-to-stable) which was fixed by accident without a regression test.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 10, 2025
@Enselic
Copy link
Member Author

Enselic commented Jun 10, 2025 •
edited
Loading

The commit of this PR is currently right before the accidental fix 4a216a2, so if the regression test works we should get a test failure (hang) on aarch64-unknown-linux-gnu.

Once that is confirmed I will rebase on master.

@Enselic
Copy link
Member Author

Enselic commented Jun 10, 2025

This PR is currently based on 39cb338 which is the commit before the accidental fix 4a216a2. Now running the new test without that fix:

@bors try parent=39cb3386ddc

@bors

This comment was marked as resolved.

Sign in to view
@Enselic
Copy link
Member Author

Enselic commented Jun 10, 2025

@workingjubilee Sorry to ping you directly but since you did 👍 I hope you don't mind:

Can you trigger the test like this please? Thanks! @bors try parent=39cb3386ddc

@bors

This comment was marked as resolved.

Sign in to view
@workingjubilee
Copy link
Member

@bors2 delegate=try

@Enselic Hi, we're testing a possible bors replacement. Can you do it now?

@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

@Enselic can now perform try builds on this pull request

@Enselic

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@Enselic
Copy link
Member Author

Enselic commented Jun 10, 2025

@bors2 try parent=39cb3386ddc6c71657418be28dbb3987eea4aa4b

@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

⌛ Trying commit 4265c65 with merge 3ca6f8f…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 10, 2025
@rust-bors
Auto merge of #142304 - Enselic:panic-main-revisions, r=<try>
3ca6f8f 
tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test

This is a regression test for #123733 (**P-high** and **regression-from-stable-to-stable**) which was [fixed by accident without a regression test](#123733 (comment)).
@workingjubilee
Copy link
Member

nice.

@rust-bors
Copy link

rust-bors bot commented Jun 11, 2025

💥 Test timed out

@workingjubilee
Copy link
Member

I have no idea what's wrong with that build, but hey delegation worked 🎆 🥳 🍾

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 11, 2025
@Enselic
Copy link
Member Author

Enselic commented Jun 11, 2025 •
edited
Loading

Yay! I really wonder what happened to that build though. I can't find any logs.

Now, I'll try the jobs.yml trick described here.

Looks like I need to get this PR out of draft mode for that ⚠️

@Enselic Enselic marked this pull request as ready for review June 11, 2025 03:34
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Enselic
Copy link
Member Author

Enselic commented Jun 11, 2025

r? @ghost

@Enselic
Copy link
Member Author

Enselic commented Jun 11, 2025 •
edited
Loading

Looks like PR CI is not run since this is based on very old commit (which is intentional). Starting an aarch64 try build now:

@bors try parent=39cb3386ddc6c71657418be28dbb3987eea4aa4b

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

@Enselic: 🔑 Insufficient privileges: not in try users

@Enselic
Copy link
Member Author

Enselic commented Jun 11, 2025

@workingjubilee Can we try regular @bors so we get logs? 😅

@workingjubilee
Copy link
Member

Absolutely.

@rust-bors
Copy link

rust-bors bot commented Jun 11, 2025

⌛ Trying commit 4c667e3 with merge d5ff42e…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 11, 2025
@rust-bors
Auto merge of #142304 - Enselic:panic-main-revisions, r=<try>
d5ff42e 
tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test

This is a regression test for #123733 (**P-high** and **regression-from-stable-to-stable**) which was [fixed by accident without a regression test](#123733 (comment)).
@workingjubilee
Copy link
Member

bors2 is the only one that understands parent=

Oh really? Damn.

@compiler-errors
Copy link
Member

May have better luck looking through the CI tab for the last try build.

cc @Kobzol for the missing logs.

@rust-bors
Copy link

rust-bors bot commented Jun 11, 2025

💔 Test failed

@Enselic

This comment was marked as outdated.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jun 11, 2025
@rust-bors
Auto merge of #142304 - Enselic:panic-main-revisions, r=<try>
4efaa98 
tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test

This is a regression test for #123733 (**P-high** and **regression-from-stable-to-stable**) which was [fixed by accident without a regression test](#123733 (comment)).
@rust-bors

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@Enselic
Copy link
Member Author

Enselic commented Jun 11, 2025 •
edited
Loading

Nope, same problem :(

Temporarily reverting 4a216a2 on master for testing was tricky but I think that's what I have to do.

@Kobzol
Copy link
Contributor

Kobzol commented Jun 11, 2025

The parent commit that you're using is too old and won't work with our current CI setup anymore.

@Enselic Enselic force-pushed the panic-main-revisions branch from 4c667e3 to fb90b98 Compare June 11, 2025 18:01
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs labels Jun 11, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
@Enselic Enselic force-pushed the panic-main-revisions branch from b0bb243 to 4c9c998 Compare June 11, 2025 18:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic Enselic force-pushed the panic-main-revisions branch from 4c9c998 to f1bf9cb Compare June 11, 2025 18:18
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic
TEMP Revert "Share inline(never) generics across crates"
cb893a9 
This reverts commit 4a216a2.
To see if the regression test works.

Changed tests are removed so I don't have to resolve conflicts.
@Enselic Enselic force-pushed the panic-main-revisions branch from f1bf9cb to f5501a5 Compare June 12, 2025 03:48
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic Enselic force-pushed the panic-main-revisions branch from f5501a5 to 0d34ea8 Compare June 12, 2025 04:02
@Enselic Enselic added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Enselic @bors @workingjubilee @rustbot @compiler-errors @Kobzol @rust-log-analyzer