Update hashbrown to 0.17 by clarfonthey · Pull Request #155154 · rust-lang/rust

clarfonthey · 2026-04-11T14:04:24Z

The main benefit of this update is to include one potential UB fix and one bug; relevant changelog entries:

Fixed potential UB in RawTableInner::fallible_with_capacity (Fix potential UB in RawTableInner::fallible_with_capacity hashbrown#692)
Fixed incorrect length if a hasher panics during rehash (Fix incorrect length if a hasher panics during rehash hashbrown#710)

Also cc @RalfJung who had also noticed the UB issue with -Zmiri-recursive-validation.

rustbot · 2026-04-11T14:04:28Z

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2026-04-11T14:04:30Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates

Amanieu · 2026-04-11T14:13:25Z

@bors try
@rust-timer queue

Update hashbrown to 0.17

Mark-Simulacrum · 2026-04-11T18:59:21Z

@bors retry

The runner looks to have hung -- looking in codebuild, it's been mostly idle for hours (though using ~91% of memory on the instance). Retrying to hopefully get a successful try build.

rust-bors · 2026-04-11T18:59:24Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Mark-Simulacrum · 2026-04-11T18:59:35Z

@bors try cancel

rust-bors · 2026-04-11T18:59:38Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/24284250899

Mark-Simulacrum · 2026-04-11T18:59:43Z

@bors try @rust-timer queue

Update hashbrown to 0.17

rust-bors · 2026-04-11T21:08:19Z

☀️ Try build successful (CI)
Build commit: c349988 (c349988acdd90492f6e7065818a76073cd73f5ab, parent: bf4fbfb7a18d74e7cd8eef93af7329c58fbb5344)

rust-timer · 2026-04-11T21:49:18Z

Finished benchmarking commit (c349988): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Max RSS (memory usage)

Results (primary 0.7%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.6%, 4.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-4.7%, -2.1%]	2
Improvements ✅ (secondary)	-4.1%	[-6.2%, -2.1%]	2
All ❌✅ (primary)	0.7%	[-4.7%, 4.7%]	5

Cycles

Results (primary -4.7%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	4.2%	[3.5%, 5.0%]	2
Improvements ✅ (primary)	-8.3%	[-8.7%, -7.8%]	2
Improvements ✅ (secondary)	-2.3%	[-2.4%, -2.2%]	2
All ❌✅ (primary)	-4.7%	[-8.7%, 2.3%]	3

Binary size

Results (primary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Bootstrap: 490.796s -> 489.879s (-0.19%)
Artifact size: 394.14 MiB -> 394.17 MiB (0.01%)

Mark-Simulacrum · 2026-04-11T21:55:57Z

@bors r+

rust-bors · 2026-04-11T21:56:00Z

📌 Commit 32d6c7f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Kobzol · 2026-04-12T09:27:17Z

Just FYI, if you run a second try build, it will automatically cancel the previous one :)

rust-bors · 2026-04-12T13:57:04Z

☀️ Test successful - CI
Approved by: Mark-Simulacrum
Duration: 3h 12m 36s
Pushing 532f8f1 to main...

github-actions · 2026-04-12T14:00:08Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 540f43a (parent) -> 532f8f1 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 532f8f1443be8f605bcc9da7968e3476d3f27d26 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-gnu-llvm-21-1: 56m 8s -> 1h 37m (+73.7%)
dist-aarch64-msvc: 1h 47m -> 1h 32m (-14.0%)
dist-apple-various: 1h 29m -> 1h 41m (+12.8%)
x86_64-gnu-llvm-21-1: 1h 7m -> 1h 13m (+10.3%)
pr-check-1: 27m 47s -> 25m 5s (-9.7%)
i686-gnu-1: 2h 13m -> 2h 1m (-9.5%)
x86_64-gnu-llvm-22-3: 1h 45m -> 1h 54m (+8.4%)
dist-x86_64-apple: 1h 54m -> 1h 45m (-8.0%)
aarch64-gnu-llvm-21-2: 46m 30s -> 50m 9s (+7.8%)
dist-aarch64-linux: 1h 45m -> 1h 52m (+7.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-12T14:38:47Z

Finished benchmarking commit (532f8f1): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.3%, 0.7%]	4
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Max RSS (memory usage)

Results (primary 1.7%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.8%, 4.0%]	3
Regressions ❌ (secondary)	4.6%	[0.8%, 8.4%]	2
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-5.0%	[-5.7%, -4.4%]	3
All ❌✅ (primary)	1.7%	[-3.9%, 4.0%]	4

Cycles

Results (secondary -6.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.8%	[-6.8%, -6.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.2%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.8%, -0.0%]	5
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	13
All ❌✅ (primary)	-0.2%	[-0.8%, -0.0%]	5

Bootstrap: 491.503s -> 490.376s (-0.23%)
Artifact size: 394.21 MiB -> 394.22 MiB (0.00%)

See library's rust-lang#155154 for the bug fixes this brings. This PR also updates `indexmap` in the compiler as a direct dependent.

compiler: update hashbrown to 0.17 See library's #155154 for the bug fixes this brings. This PR also updates `indexmap` in the compiler as a direct dependent.

compiler: update hashbrown to 0.17 See library's rust-lang/rust#155154 for the bug fixes this brings. This PR also updates `indexmap` in the compiler as a direct dependent.

Update hashbrown to 0.17

32d6c7f

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 11, 2026

rustbot assigned Mark-Simulacrum Apr 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Apr 11, 2026

Auto merge of #155154 - clarfonthey:hashbrown-0.17, r=<try>

9089290

Update hashbrown to 0.17

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Apr 11, 2026

Auto merge of #155154 - clarfonthey:hashbrown-0.17, r=<try>

c349988

Update hashbrown to 0.17

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2026

rust-bors Bot merged commit 532f8f1 into rust-lang:main Apr 12, 2026
13 checks passed

rustbot added this to the 1.97.0 milestone Apr 12, 2026

clarfonthey deleted the hashbrown-0.17 branch April 12, 2026 15:16

cuviper added a commit to cuviper/rust that referenced this pull request Apr 13, 2026

compiler: update hashbrown to 0.17

6e618be

See library's rust-lang#155154 for the bug fixes this brings. This PR also updates `indexmap` in the compiler as a direct dependent.

cuviper mentioned this pull request Apr 13, 2026

compiler: update hashbrown to 0.17 #155256

Merged

Uh oh!

Conversation

clarfonthey commented Apr 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

rustbot commented Apr 11, 2026

Uh oh!

Amanieu commented Apr 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum commented Apr 11, 2026

Uh oh!

rust-bors Bot commented Apr 11, 2026

Uh oh!

Mark-Simulacrum commented Apr 11, 2026

Uh oh!

rust-bors Bot commented Apr 11, 2026

Uh oh!

Mark-Simulacrum commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 11, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 11, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Mark-Simulacrum commented Apr 11, 2026

Uh oh!

rust-bors Bot commented Apr 11, 2026

Uh oh!

Kobzol commented Apr 12, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 12, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Apr 12, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

clarfonthey commented Apr 11, 2026 •

edited by rustbot

Loading

Mark-Simulacrum commented Apr 11, 2026 •

edited

Loading