implement into_array for Vec<T>#156234
Open
bend-n wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
into_array_for_vec_t_via_boxed_array
branch
from
09b6441 to
12ff256
Compare
tbu-
reviewed
May 6, 2026
| #[cfg(not(no_global_oom_handling))] | ||
| #[unstable(feature = "alloc_slice_into_array", issue = "148082")] | ||
| #[must_use] | ||
| pub fn into_array<const N: usize>(self) -> Option<Box<[T; N], A>> { |
Contributor
There was a problem hiding this comment.
Should probably return Result<_, Self>.
Contributor
Author
There was a problem hiding this comment.
every into_array is like this.
Contributor
There was a problem hiding this comment.
The tracking issue that you link (#148082) says it should be a Result. It also makes sense for this to be a Result: This way, you can recover the allocation if the conversion fails.
Contributor
Author
There was a problem hiding this comment.
the tracking issue doesn't say that, some random person says that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for more into_array coverage and to avoid harmful obtuse opaque try_into calls