add a few new solver normalization tests#156250
Open
lqd wants to merge 3 commits intorust-lang:mainfrom
Open
Conversation
There were fixed by rust-lang#140672
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
This comment was marked as resolved.
This comment was marked as resolved.
Another example from rust-lang/trait-system-refactor-initiative#139 and which was likely fixed by rust-lang#140672 as well.
Another example from rust-lang/trait-system-refactor-initiative#139 and which was fixed in 1.89 `nightly-2025-06-18`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on zulip, this PR adds the handful of new solver revisions and tests from rust-lang/trait-system-refactor-initiative#139. The cases that issue mentions were already fixed by #140672 in 1.88, then in 1.89
nightly-2025-06-18, and some cases, we expect, by #155767.Closes rust-lang/trait-system-refactor-initiative#139.
r? lcnr
I'm not sure where the best place for the tests would be, do you have a better location in mind?