Overflow when rounding delivers the largest finite value - #37
Open
Garfield1002 wants to merge 2 commits into
Open
Garfield1002 wants to merge 2 commits into
Garfield1002 wants to merge 2 commits into
Conversation
IEEE 754 raises the overflow exception whenever the largest finite number is exceeded in magnitude by the result unbounded exponent range would have produced, whichever value the rounding mode then delivers. Rounding toward zero delivers the largest finite number rather than infinity, and `overflow_result` reported only the inexact result for that case. This mirrored LLVM's `handleOverflow`, which has the same omission, so the expectations that encoded it are updated alongside. Consumers that check the flag - x87 emulation, where hardware raises OE - could not otherwise distinguish an overflow from an ordinary inexact result: both deliver the largest finite value.
Member
|
Thanks for putting this together! I'm going to hold off and wait for the LLVM fix to go through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36