Fix __eh_frame for AArch64 on macOS#1634
Merged
bjorn3 merged 3 commits intorust-lang:mainfrom Apr 23, 2026
Merged
Conversation
bjorn3
reviewed
Apr 22, 2026
bjorn3
reviewed
Apr 22, 2026
Member
|
CI failure is because of rust-lang/cargo#16925 |
The relocations must use symbols (not sections), and the relative relocation needs ARM64_RELOC_SUBTRACTOR. The section must be in __TEXT rather than __DWARF, which is handled by using StandardSection::EhFrame. This also changes the section type for ELF x86-64.
bjorn3
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relocations must use symbols (not sections), and the relative relocation needs ARM64_RELOC_SUBTRACTOR.
The section must be in __TEXT rather than __DWARF, which is handled by using StandardSection::EhFrame. This also changes the section type for ELF x86-64.
Depends on gimli-rs/object#856