Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve doc for new contributors #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve doc for new contributors #586

wants to merge 2 commits into from

Conversation

g4titanx
Copy link
Contributor

@g4titanx g4titanx commented Jan 3, 2025

this PR fixes issue #562

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 3, 2025

@antoyo

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 8, 2025

@antoyo waiting on a review for this too

@antoyo
Copy link
Contributor

antoyo commented Jan 8, 2025

It might take a few more days before I can get to review this.
Sorry for the delay.

@g4titanx g4titanx mentioned this pull request Feb 6, 2025
Open
antoyo
antoyo reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.
Here's a few suggestions for improvement.

@antoyo
Copy link
Contributor

antoyo commented Feb 8, 2025

There's a conflict, so please rebase on the master branch and resolve the conflict.

@g4titanx
Copy link
Contributor Author

There's a conflict, so please rebase on the master branch and resolve the conflict.

done, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g4titanx @antoyo