Skip to content

Replace hand-written markdown normalization with proper stripping#2338

Merged
Urgau merged 2 commits intorust-lang:masterfrom
Urgau:strip-markdown
Mar 10, 2026
Merged

Replace hand-written markdown normalization with proper stripping#2338
Urgau merged 2 commits intorust-lang:masterfrom
Urgau:strip-markdown

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Mar 7, 2026

@Urgau Urgau requested a review from Kobzol March 7, 2026 19:58
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder if we actually want to strip everything in the Zulip output though? I would say yes for titles, but not sure about comment bodies. Though I checked the user-info output now and it looks like it might be a bit easier to read without any Markdown.

View changes since this review

@Urgau
Copy link
Member Author

Urgau commented Mar 10, 2026

I don't know, it seems fine to keep strike-trough, bold, and italics, but unsure about the rest.

I'd say let's try it and see how it goes.

@Urgau Urgau added this pull request to the merge queue Mar 10, 2026
Merged via the queue into rust-lang:master with commit d0d79c2 Mar 10, 2026
3 checks passed
@Urgau Urgau deleted the strip-markdown branch March 10, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants