Use BTreeMap instead of HashMap for deterministic serialization#105
Closed
mbr wants to merge 1 commit into
Closed
Conversation
Member
|
Hey @mbr , thanks for the suggestion ⭐ . this is a great improvement and something I didn’t initially think of. I will update the schema generator accordingly, It may introduce a breaking change, so I’ll need to evaluate the impact before releasing this change. I may bundle it with the upcoming larger changes to the rust-mcp-sdk |
Member
|
This was addressed in in #108 and released in #109 . Also available in rust-mcp-sdk-v0.9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Solves the problem of having non-deterministic tool definitions, the order changes around when getting large.
✨ Changes Made
Replaced all
HashMapswithBTreeMaps🛠️ Testing Steps
cargo testsufficient, I assume.💡 Additional Notes
I did not dig too deep into how the code in this repo is generated and whether there's a better place to apply these changes. I am currently happily using my forked branch.
This PR is aimed at the latest release version, not main.