Skip to content

Fix GameActivity touch inputs in the presence of a stylus #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GameActivity touch inputs in the presence of a stylus #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e80d8a
logs: rename threaded_app log identifier to android_activity
jb55 Mar 11, 2025
3de4f3a
gameactivity: don't discard stylus touchscreen inputs
jb55 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions android-activity/game-activity-csrc/game-activity/native_app_glue/android_native_app_glue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
#define NATIVE_APP_GLUE_KEY_EVENTS_DEFAULT_BUF_SIZE 4

#define LOGI(...) \
((void)__android_log_print(ANDROID_LOG_INFO, "threaded_app", __VA_ARGS__))
((void)__android_log_print(ANDROID_LOG_INFO, "android_activity", __VA_ARGS__))
#define LOGE(...) \
((void)__android_log_print(ANDROID_LOG_ERROR, "threaded_app", __VA_ARGS__))
((void)__android_log_print(ANDROID_LOG_ERROR, "android_activity", __VA_ARGS__))
#define LOGW(...) \
((void)__android_log_print(ANDROID_LOG_WARN, "threaded_app", __VA_ARGS__))
((void)__android_log_print(ANDROID_LOG_WARN, "android_activity", __VA_ARGS__))
#define LOGW_ONCE(...) \
do { \
static bool alogw_once##__FILE__##__LINE__##__ = true; \
Expand All @@ -46,7 +46,7 @@
/* For debug builds, always enable the debug traces in this library */
#ifndef NDEBUG
#define LOGV(...) \
((void)__android_log_print(ANDROID_LOG_VERBOSE, "threaded_app", \
((void)__android_log_print(ANDROID_LOG_VERBOSE, "android_activity", \
__VA_ARGS__))
#else
#define LOGV(...) ((void)0)
Expand Down Expand Up @@ -264,7 +264,7 @@ static bool default_key_filter(const GameActivityKeyEvent* event) {

static bool default_motion_filter(const GameActivityMotionEvent* event) {
// Ignore any non-touch events.
return event->source == SOURCE_TOUCHSCREEN;
return event->source & SOURCE_TOUCHSCREEN;
}

// --------------------------------------------------------------------
Expand Down