Skip to content

Re-export 'ndk' and 'ndk_sys' crates #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Re-export 'ndk' and 'ndk_sys' crates #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android-activity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
> - `SourceFlags::TRACKBALL` (from `Source::is_trackball_class()`) is named `SourceClass::NAVIGATION` in the `ndk`.

- rust-version bumped to 1.73.0 ([#193](https://github.com/rust-mobile/android-activity/pull/193))
- The `ndk` and `ndk-sys` crates are now re-exported under `android_activity::ndk` and `android_activity::ndk_sys` ([#194](https://github.com/rust-mobile/android-activity/pull/194))

## [0.6.0] - 2024-04-26

Expand Down
10 changes: 8 additions & 2 deletions android-activity/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,17 @@ use std::sync::Arc;
use std::sync::RwLock;
use std::time::Duration;

use input::KeyCharacterMap;
use bitflags::bitflags;
use libc::c_void;

use ndk::asset::AssetManager;
use ndk::native_window::NativeWindow;

use bitflags::bitflags;
// Since we expose `ndk` types in our public API it's convenient if crates can
// defer to these re-exported APIs and avoid having to bump explicit
// dependencies when they pull in new releases of android-activity.
Comment on lines +128 to +130
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflow for line length?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'dependencies' is a surprisingly long word I suppose :)

I use a vscode plugin for wrapping at various column widths and this is already wrapped:
image

Copy link
Member

@MarijnS95 MarijnS95 Apr 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it can't reflow dependencies even though crates can on the first line looks out of place.

I tried helix which reflows it to 128 columns for some reason... Either way, IIRC they recently switched to an algorithm that tries to keep a balanced length while maintaining a maximum, rather than breaking whenever the next word would have gone over the limit.

pub use ndk;
pub use ndk_sys;

#[cfg(not(target_os = "android"))]
compile_error!("android-activity only supports compiling for Android");
Expand Down Expand Up @@ -162,6 +167,7 @@ pub mod error;
use error::Result;

pub mod input;
use input::KeyCharacterMap;

mod config;
pub use config::ConfigurationRef;
Expand Down