Fix hidden lifetime warning #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Aug 11, 2025
| /// This must only be called from your `android_main()` thread and it may panic if called | ||
| /// from another thread. | ||
| pub fn input_events_iter(&self) -> Result<input::InputIterator> { | ||
| pub fn input_events_iter(&'_ self) -> Result<input::InputIterator<'_>> { |
There was a problem hiding this comment.
If you apply the suggestion on self it does this. If you apply the suggestion on InputIterator I think it only suggests this:
Suggested change
| pub fn input_events_iter(&'_ self) -> Result<input::InputIterator<'_>> { | |
| pub fn input_events_iter(&self) -> Result<input::InputIterator<'_>> { |
There was a problem hiding this comment.
See also #184 where I fixed exactly this.
There was a problem hiding this comment.
ah, yup, will merge that instead, thanks.
|
Will merge #184 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current CI issue when building with the latest stable toolchain