Skip to content

Fix parsing of abstract Unix socket addresses#19

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
viccie30:fix-abstract-unix-socket-addresses
Jul 3, 2026
Merged

Fix parsing of abstract Unix socket addresses#19
cathay4t merged 1 commit into
rust-netlink:mainfrom
viccie30:fix-abstract-unix-socket-addresses

Conversation

@viccie30

@viccie30 viccie30 commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

These start with a null byte, don't end with a null byte and can contain embedded null bytes.

I changed the type of pathname alternative to OSString, because paths are not necessarily valid UTF-8.

Comment thread src/unix/nlas.rs Outdated
@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.12%. Comparing base (f5f4ad7) to head (44c9d11).

Files with missing lines Patch % Lines
src/unix/response.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   39.34%   42.12%   +2.77%     
==========================================
  Files          11       11              
  Lines         854      895      +41     
==========================================
+ Hits          336      377      +41     
  Misses        518      518              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccie30
viccie30 force-pushed the fix-abstract-unix-socket-addresses branch from 44c9d11 to aff1abb Compare February 12, 2025 09:27
These start with a null byte, don't end with a null byte and can contain
embedded null bytes.
@cathay4t
cathay4t force-pushed the fix-abstract-unix-socket-addresses branch from aff1abb to 5a5c4cc Compare July 3, 2026 00:59
@cathay4t
cathay4t enabled auto-merge (rebase) July 3, 2026 00:59
@cathay4t
cathay4t merged commit f14c57f into rust-netlink:main Jul 3, 2026
3 checks passed
@cathay4t

cathay4t commented Jul 3, 2026

Copy link
Copy Markdown
Member

I made some changes to fix into new code base: Use netlink-packet-core 0.8 new code style on error handling and data types.

@cathay4t

cathay4t commented Jul 3, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the contribution!

@viccie30
viccie30 deleted the fix-abstract-unix-socket-addresses branch July 3, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants