Skip to content

Add license file#17

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:main
May 8, 2026
Merged

Add license file#17
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:main

Conversation

@cathay4t

@cathay4t cathay4t commented May 8, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Gris Ge <cnfourt@gmail.com>
@cathay4t cathay4t changed the title Add license tile Add license file May 8, 2026
@cathay4t
cathay4t merged commit d37a398 into rust-netlink:main May 8, 2026
3 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a LICENSE-MIT file to the project. The review feedback identifies that the license text includes a non-standard paragraph (lines 11-17) regarding the modification of bug reporting information. This custom clause creates a discrepancy with the standard MIT license specified in the package metadata, which may cause issues with automated license detection and compliance tools.

Comment thread LICENSE-MIT
Comment on lines +11 to +18
Distributions of all or part of the Software intended to be used by the
recipients as they would use the unmodified Software, containing modifications
that substantially alter, remove, or disable functionality of the Software,
outside of the documented configuration mechanisms provided by the Software,
shall be modified such that the Original Author's bug reporting email addresses
and urls are either replaced with the contact information of the parties
responsible for the changes, or removed entirely.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The included paragraph (lines 11-17) is not part of the standard MIT license. Since the project's Cargo.toml specifies 'MIT' as the license, this additional clause creates a discrepancy that may interfere with automated license detection and compliance. It is recommended to use the standard MIT license text to ensure consistency with the package metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant